Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Ctrl-C processing & use as lib with recent python versions #960

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Fix Ctrl-C processing & use as lib with recent python versions #960

merged 2 commits into from
Oct 27, 2023

Conversation

cathales
Copy link
Contributor

@cathales cathales commented Oct 9, 2023

Hello,

We are using riscv-dv with two patches to verify CVA6. We hope it will help everyone if those patches are made common.

  1. The simulation was still running after hitting Ctrl-C. With this PR it is correctly killed. It is a continuation of work from @yanicasa fixing the same issue for timeouts.
  2. We are using riscv-dv as a library with a relative path dv.scripts. Python 3.9 cannot find it albeit Python 3.7 had no issues finding it. To fix this, we found this link and added an empty __init__.py file.

@cathales
fix Ctrl-C processing
686e234
@cathales
fix for recent python versions
41284d6 
With newest Python versions, dv.scripts module cannot be found if dv is
used as a submodule.
This modifications adds an empty `__init__.py` file so that it can be
found by Python 3.9.
@cathales cathales mentioned this pull request Oct 10, 2023
Closed
1 task
@cathales cathales changed the title Fixes Fix Ctrl-C processing & use as lib with recent python versions Oct 12, 2023
@JeanRochCoulon
Copy link

Hello,
Thank you to have reviewed and approved this PR. In OpenHW Group, and more precisely in CVA6 project, we are glad to use the riscv-dv project.
We try to be synchronized with this repository by declaring it as submodule. As you know the drawback to declare it as submodule is that we are dependant of it. Today we would be pleased to ugrade the riscv-dv hash, but we are waiting for this PR merge since two weeks. It would be great if you cold merge it on master. It would unlock cva6 project.

kgugala
kgugala approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@kgugala kgugala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgugala kgugala merged commit f0c570d into chipsalliance:master Oct 27, 2023
34 checks passed
@cathales cathales deleted the fixes branch November 3, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcockrell-google mcockrell-google mcockrell-google approved these changes

@kgugala kgugala kgugala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cathales @JeanRochCoulon @kgugala @mcockrell-google